Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernization galore #243

Merged
merged 29 commits into from
Oct 12, 2023
Merged

Modernization galore #243

merged 29 commits into from
Oct 12, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 12, 2023 •
edited
Loading

Please use SQUASH AND MERGE button!

After merge:

  • Open follow up issue about CI not able to see math_util C-ext (NUMPY_EXPERIMENTAL_DTYPE_API) and the xfail. Maybe tox is preventing the CI to see the .so file but I don't know how to fix. synphot works just fine with tox (though not OpenAstronomy) and astropy also works fine (with OpenAstronomy). (fixed!)
  • Open issues about aarch64 wheels unable to be built (takes too long). manylinux_aarch64: Takes too long to build #247
  • Update branch protection rules. (done!)
  • Someone with admin access to PyPI for this package needs to generate a token and add it as PYPI_TOKEN repo secret here. PyPI admin: Need a PYPI_TOKEN #249
  • In the next release, merely a tag would generate a release, so don't tag for fun!
  • In the next release, if successful, users will be able to get all sorts of wheels from PyPI and have to rely less on conda.

pllim added 5 commits October 11, 2023 21:46
@pllim
Move CI to tox
61c2219
@pllim
Move setup.cfg to pyproject.toml
8e50cce 
and add flake8 check. Also clean up flake8 warnings.
@pllim
Move benchmark module out of unit tests area.
dce4f77 
Move test helper functions into helpers.py instead of having them spread out in test modules that do not contain tests.
Remove CLI from test modules because we use pytest now.
@pllim
Use OpenAstronomy to build wheels
56e903f
@pllim
Use absolute imports
9cf7b4e
@pllim pllim added the Build wheels Build wheels on PR label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
spherical_geometry/__init__.py 100.00% <100.00%> (ø)
spherical_geometry/graph.py 93.19% <100.00%> (+0.03%) ⬆️
spherical_geometry/polygon.py 82.37% <100.00%> (-0.05%) ⬇️
spherical_geometry/vector.py 84.48% <ø> (+2.81%) ⬆️
spherical_geometry/great_circle_arc.py 39.53% <12.50%> (-1.69%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pllim pllim mentioned this pull request Oct 12, 2023
Open
@pllim pllim mentioned this pull request Oct 12, 2023
Open
pllim added 6 commits October 12, 2023 01:42
@pllim
Match package_data closer to old definition
a1a626a 
because there must be some black magic happening.

Ignore problematic test in wheel building.

Fix pytest path mismatch error for sdist job.
@pllim
Cannot be empty string on LHS
da978c8
@pllim
Fix setuptols discovery
4819e45
@pllim
What if we do not changedir in tox
33c63c2
@pllim
Do not include docs in test paths.
23f460b 
Also disabling changedir had no effect
@pllim
xfail tests that fail with numpy alt func
a10b4c1 
and enable limited wheel test for all PRs
@pllim pllim marked this pull request as ready for review October 12, 2023 06:54
@pllim pllim requested a review from a team as a code owner October 12, 2023 06:54
@pllim pllim mentioned this pull request Oct 12, 2023
Open
@pllim pllim mentioned this pull request Oct 12, 2023
Closed
This was referenced Oct 12, 2023
Open
Closed
@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

Despite the scary diff, users won't actually see anything different. All they will get are new wheels after next release. So no need for change log.

@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

This is in a good state now, so I am going to YOLO merge it. If you run into problems, will be happy to come back to help. Enjoy your wheels!

@pllim pllim merged commit 44f9595 into spacetelescope:master Oct 12, 2023
22 of 23 checks passed
@pllim pllim deleted the tox-tox-toxic branch October 12, 2023 15:33
pllim added a commit that referenced this pull request Oct 12, 2023
@pllim
Changed my mind about the change log
d0e3099 
for #243
@pllim pllim mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build wheels Build wheels on PR
Projects
None yet
Milestone
No milestone
1 participant
@pllim