Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial it up to 11 #246

Closed
wants to merge 28 commits into from
Closed

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Oct 12, 2023

Why, tox, why. So close.

pllim added 26 commits October 11, 2023 21:46
and add flake8 check. Also clean up flake8 warnings.
Move test helper functions into helpers.py instead of having them spread out in test modules that do not contain tests.
Remove CLI from test modules because we use pytest now.
and do not change dir for tox because there is C-ext
because there must be some black magic happening.

Ignore problematic test in wheel building.

Fix pytest path mismatch error for sdist job.
Also disabling changedir had no effect
and enable limited wheel test for all PRs
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Files Coverage Δ
spherical_geometry/__init__.py 100.00% <100.00%> (ø)
spherical_geometry/graph.py 93.19% <100.00%> (+0.03%) ⬆️
spherical_geometry/polygon.py 82.37% <100.00%> (-0.05%) ⬇️
spherical_geometry/vector.py 84.48% <ø> (+2.81%) ⬆️
spherical_geometry/great_circle_arc.py 39.53% <12.50%> (-1.69%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@pllim pllim added the Build wheels Build wheels on PR label Oct 12, 2023
@pllim pllim removed the Build wheels Build wheels on PR label Oct 12, 2023
@pllim pllim added the Build wheels Build wheels on PR label Oct 12, 2023
@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

OK I am happy with the test logs now. Maybe I'll merge this back to #243

@pllim pllim closed this Oct 12, 2023
@pllim pllim deleted the tox-why-u-like-that branch October 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build wheels Build wheels on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant