Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux_aarch64: Takes too long to build #247

Open
pllim opened this issue Oct 12, 2023 · 7 comments
Open

manylinux_aarch64: Takes too long to build #247

pllim opened this issue Oct 12, 2023 · 7 comments
Labels
bug maintenance Package maintenance

Comments

@pllim
Copy link
Contributor

pllim commented Oct 12, 2023

Couldn't pull it off in #243 . Took way longer than other archs and I didn't have the patience or interest to find out why.

No one uses this package in that architecture and somehow need the wheel from PyPI, right?

@falkben
Copy link
Member

falkben commented Oct 12, 2023

It would be very convenient to be able to install on developer macs instead of needing to build from source each time.

Edit: sorry, misread or didn't see the title. I now see you only mean linux arm64 (aarch64). I can see the macosx arm64 whl files in the latest artifacts.

We would not be using this any time soon -- the only thing I can think of is that it would enable us to run applications on arm CPU's in the cloud (e.g. graviton) which can be slightly less costly. Not urgent.

@pllim
Copy link
Contributor Author

pllim commented Oct 12, 2023

Yes, OSX ARM should have a wheel when the new release is out.

@AstroPatty
Copy link

I did run into a potential use case of this that might be relevant. I have a project that executes tests in a container. I'm on an M Series Mac, which by default built the container as an arm64 linux container. The build failed because spherical-geometry doesn't have a wheel for that combo.

I can force it to build as x86, so it's not a big issue. But still a +1 for fixing this eventually. I can maybe try to put some time into this sometime.

@pllim
Copy link
Contributor Author

pllim commented Jan 25, 2024

@PatrickRWells , I am confused. This issue is about manylinux_aarch64, not M-series Mac. There should be wheels for OSX ARM64 already. See https://pypi.org/project/spherical-geometry/#files

Are you using a very old Python? You need Python 3.9 or later.

@falkben
Copy link
Member

falkben commented Jan 25, 2024

@pllim They are running in linux (docker) so this does apply.

@pllim
Copy link
Contributor Author

pllim commented Jan 25, 2024

In that case, don't use a manylinux_aarch64 container if possible. I have no solution to this problem and I am not a maintainer of this package, so I don't have any ETA for this fix.

@pllim
Copy link
Contributor Author

pllim commented May 15, 2024

Might want to revisit this again when numpy 2.x stuff is settled. Please ping us again if we forget. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maintenance Package maintenance
Projects
None yet
Development

No branches or pull requests

3 participants