Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent entities who do not have hands from setting off bombs. #22250

Merged

Conversation

nok-ko
Copy link
Member

@nok-ko nok-ko commented Dec 9, 2023

About the PR

Prevents entities without hands from changing a bomb’s timer or detonating a bomb.

This is my first PR to this repository, please let me know about anything I can improve. I originally submitted this change to the Delta-V fork but was told by its maintainers to put it upstream. (Whoops.) I have tested that it works the same way here.

Why / Balance

Applies to proper Syndicate Bombs, and practice bombs, which were previously operable to all sorts of miscreants (e.g. mice) — that was bad. Entities without hands could also change the timers on sticks of C4 and the Spider Clan Charges, but not detonate them.

Technical details

Adds an extra check to the OnGetAltVerbs event handlers in DefusableSystem and TriggerSystem.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Bomb verbs are present when playing as a character with hands:
image

Absent when playing as one without:
image

Breaking changes

Changelog

🆑

  • fix: Entities without hands (like mice and mothroaches) are now forbidden from operating Syndicate Bombs, C4, and other timed explosives.

@nok-ko nok-ko requested a review from ElectroJr as a code owner December 9, 2023 00:04
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Dec 9, 2023
@metalgearsloth metalgearsloth merged commit e5fb355 into space-wizards:master Dec 10, 2023
11 checks passed
BasedUser pushed a commit to BasedUser/space-station-14 that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants