Prevent entities who do not have hands from setting off bombs. #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not upstream this |
|
Should upstream this but I will make mouse ops the exception. I like to imagine they're like the guinea pigs from G-Force but evil. |
|
This should be upstreamed |
|
i imagine you could have mouse op have a hands component with no actual hands, so it can change timers and stuff |
|
Whoops, you’re all very right. |
Merged
1 task
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Fixes DeltaV-Station#529 A crash course that I need to check when a component is networked. Now actually replicates pocket vision to the client. # Changelog :cl: - fix: Fixed thieving trait not granting pocket vision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Prevents entities without hands from changing a bomb’s timer or detonating a bomb. This is my first PR to this repository, please let me know about anything I can improve.
Why / Balance
Applies to proper Syndicate Bombs, and practice bombs, which were previously operable to all sorts of miscreants (e.g. mice) — that was bad. Entities without hands could also change the timers on sticks of C4 and the Spider Clan Charges, but not detonate them.
Technical details
Adds an extra check to the
OnGetAltVerbsevent handlers inDefusableSystemandTriggerSystem.Media
Bomb verbs are present when playing as a character with hands:
Absent when playing as one without:
Breaking changes
Changelog
🆑