Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-973444: Change Prepare to be handled as a Noop #894

Merged
merged 3 commits into from
Jul 19, 2024
Merged

SNOW-973444: Change Prepare to be handled as a Noop #894

merged 3 commits into from
Jul 19, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Mar 20, 2024 •
edited
Loading

Description

Change Prepare method to be handled as a noop, removed throw NotImplementedException.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner March 20, 2024 13:35
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Mar 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@9736edd). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #894   +/-   ##
=========================================
  Coverage          ?   85.61%           
=========================================
  Files             ?      106           
  Lines             ?    10777           
  Branches          ?     1032           
=========================================
  Hits              ?     9227           
  Misses            ?     1300           
  Partials          ?      250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-973444-dbprepare-noop branch from f9694cd to 3ced9b5 Compare May 8, 2024 21:46
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit 982a1e4 into master Jul 19, 2024
53 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-973444-dbprepare-noop branch July 19, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-erojaslizano sfc-gh-erojaslizano sfc-gh-erojaslizano left review comments

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-jmartinezramirez @sfc-gh-erojaslizano @sfc-gh-dprzybysz @sfc-gh-knozderko @sfc-gh-mhofman