Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-970839: Prepare should not throw #812

Closed
mgravell opened this issue Nov 15, 2023 · 4 comments
Closed

SNOW-970839: Prepare should not throw #812

mgravell opened this issue Nov 15, 2023 · 4 comments
Assignees
@sfc-gh-snow-drivers-warsaw-dl
Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@mgravell
Copy link

mgravell commented Nov 15, 2023 •
edited
Loading

Currently, DbCommand.Prepare is implemented as a throw: https://github.com/snowflakedb/snowflake-connector-net/blob/master/Snowflake.Data/Client/SnowflakeDbCommand.cs#L236-L239

If Prepare() is not required, IMO this should be a simple no-op; callers may not know what specific provider library is being used (think "Dapper" etc), so the API should be usable even if it does nothing when not required.
@mgravell mgravell added the bug label Nov 15, 2023
@github-actions github-actions bot changed the title Prepare should not throw SNOW-970839: Prepare should not throw Nov 15, 2023
@sfc-gh-dszmolka
Copy link
Contributor

hi and thank you for raising this issue ! I see your point, however not entirely sure if this is a bug - we're going to take a look regardless.

@sfc-gh-dszmolka sfc-gh-dszmolka added the status-in_progress Issue is worked on by the driver team label Nov 17, 2023
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed bug status-in_progress Issue is worked on by the driver team labels Feb 11, 2024
@sfc-gh-dszmolka
Copy link
Contributor

PR in review #894

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-pr_pending_merge A PR is made and is under review labels Mar 20, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Jul 21, 2024
@sfc-gh-dszmolka
Copy link
Contributor

fix is merged and will be part of the next driver release

@sfc-gh-dszmolka
Copy link
Contributor

released with v4.1.0 of the Snowflake .NET driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-snow-drivers-warsaw-dl sfc-gh-snow-drivers-warsaw-dl

Labels
enhancement The issue is a request for improvement or a new feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mgravell @sfc-gh-dszmolka @sfc-gh-triage-snowpark-ecosystem-dl @sfc-gh-snow-drivers-warsaw-dl