Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-973444: Change Prepare to be handled as a Noop #894

Merged
merged 3 commits into from
Jul 19, 2024
Merged

SNOW-973444: Change Prepare to be handled as a Noop #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dead63
Change Prepare to be handled as a Noop
sfc-gh-jmartinezramirez Mar 20, 2024
fbfa8d6
Updated test to validate that not throws any exception
sfc-gh-jmartinezramirez Mar 20, 2024
13f2a30
Applying PR suggestions
sfc-gh-jmartinezramirez Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Snowflake.Data.Tests/UnitTests/SFDbCommandTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ public void TestCommandExecuteAsyncThrowsExceptionWhenCommandTextIsNotSet()
}

[Test]
public void TestCommandPrepareThrowsNotImplemented()
public void TestCommandPrepareShouldNotThrowsException()
{
Assert.Throws<NotImplementedException>(() => command.Prepare());
Assert.DoesNotThrow(() => command.Prepare());
}
}
}
5 changes: 4 additions & 1 deletion Snowflake.Data/Client/SnowflakeDbCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,12 @@ public override async Task<object> ExecuteScalarAsync(CancellationToken cancella
return DBNull.Value;
}

/// <summary>
/// Prepares the command for execution.
/// This method is currently not implemented and acts as a no-operation (Noop).
/// </summary>
public override void Prepare()
{
throw new NotImplementedException();
}

public string GetQueryId()
Expand Down
Loading