Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TLS connection between node and OTEL collector for traces #11278

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Adding TLS connection between node and OTEL collector for traces #11278

merged 8 commits into from
Nov 22, 2023

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Nov 14, 2023 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@patrickhuie19 patrickhuie19 mentioned this pull request Nov 14, 2023
Merged
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch 4 times, most recently from fabc2d7 to ab245c7 Compare November 14, 2023 07:17
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from e0e9a2c to 963f950 Compare November 15, 2023 03:15
@patrickhuie19 patrickhuie19 marked this pull request as ready for review November 15, 2023 03:16
@patrickhuie19 patrickhuie19 requested review from a team and jkongie as code owners November 15, 2023 03:16
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from 963f950 to 0924699 Compare November 15, 2023 03:42
krehermann
krehermann reviewed Nov 15, 2023
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 15, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 15, 2023
View reviewed changes
core/config/toml/types.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 15, 2023
View reviewed changes
GNUmakefile Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 15, 2023
View reviewed changes
core/web/assets/index.html Outdated Show resolved Hide resolved
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from 7f4e208 to a186db4 Compare November 15, 2023 19:20
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from a186db4 to c4289e0 Compare November 15, 2023 19:26
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch 4 times, most recently from cf66f0d to 5d4285a Compare November 22, 2023 03:24
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from 5d4285a to eb4428c Compare November 22, 2023 05:32
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from eb4428c to de6ad7a Compare November 22, 2023 05:33
jmank88
jmank88 reviewed Nov 22, 2023
View reviewed changes
core/config/docs/core.toml Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 22, 2023
View reviewed changes
core/config/toml/types.go Outdated Show resolved Hide resolved
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from 6c1843c to bbebea7 Compare November 22, 2023 14:30
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@patrickhuie19 patrickhuie19 added this pull request to the merge queue Nov 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2023
@patrickhuie19 patrickhuie19 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into develop with commit bde6a2a Nov 22, 2023
88 checks passed
@patrickhuie19 patrickhuie19 deleted the feature/tracing-credentials branch November 22, 2023 18:15
@dmitry-diginex dmitry-diginex mentioned this pull request Dec 3, 2023
Open
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@jkongie jkongie Awaiting requested review from jkongie

@krehermann krehermann Awaiting requested review from krehermann

@essamhassan essamhassan Awaiting requested review from essamhassan

@samsondav samsondav Awaiting requested review from samsondav

@secureandrew secureandrew Awaiting requested review from secureandrew

@CL-Andrew CL-Andrew Awaiting requested review from CL-Andrew

@chainchad chainchad Awaiting requested review from chainchad

@javuto javuto Awaiting requested review from javuto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhuie19 @CL-Andrew @jmank88 @krehermann