Skip to content

Commit

Permalink
feature/tracing-credentials: minor docs refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhuie19 committed Nov 22, 2023
1 parent de6ad7a commit bbebea7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/config/docs/core.toml
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ CollectorTarget = 'localhost:4317' # Example
NodeID = 'NodeID' # Example
# SamplingRatio is the ratio of traces to sample for this node.
SamplingRatio = 1.0 # Example
# Mode is a string value. 'tls' or 'unencrypted' are the only values allowed. If set to 'unencrypted', TLSCertPath can be unset, meaning traces will be sent over plaintext to the collector.
# Mode is a string value. `tls` or `unencrypted` are the only values allowed. If set to `unencrypted`, `TLSCertPath` can be unset, meaning traces will be sent over plaintext to the collector.
Mode = 'tls' # Default
# TLSCertPath is the file path to the TLS certificate used for secure communication with an OTEL Tracing Collector.
TLSCertPath = '/path/to/cert.pem' # Example
Expand Down
2 changes: 1 addition & 1 deletion core/config/toml/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,7 @@ func isValidURI(uri string) bool {
return isValidLocalURI(uri)
}

// Validates uri is a valid local URI
// isValidLocalURI returns true if uri is a valid local URI
// External URIs (e.g. http://) are not valid local URIs, and will return false.
func isValidLocalURI(uri string) bool {
parts := strings.Split(uri, ":")
Expand Down
2 changes: 1 addition & 1 deletion docs/CONFIG.md
Original file line number Diff line number Diff line change
Expand Up @@ -1631,7 +1631,7 @@ SamplingRatio is the ratio of traces to sample for this node.
```toml
Mode = 'tls' # Default
```
Mode is a string value. 'tls' or 'unencrypted' are the only values allowed. If set to 'unencrypted', TLSCertPath can be unset, meaning traces will be sent over plaintext to the collector.
Mode is a string value. `tls` or `unencrypted` are the only values allowed. If set to `unencrypted`, `TLSCertPath` can be unset, meaning traces will be sent over plaintext to the collector.

### TLSCertPath
```toml
Expand Down

0 comments on commit bbebea7

Please sign in to comment.