Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiring through Tracing.TLSCertPath from TOML config #237

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Wiring through Tracing.TLSCertPath from TOML config #237

merged 5 commits into from
Nov 15, 2023

Conversation

patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Nov 14, 2023 •
edited
Loading

@patrickhuie19 patrickhuie19 changed the title feature/tracing-credentials: wiring through Tracing.TLSCertPath from TOML config Wiring through Tracing.TLSCertPath from TOML config Nov 14, 2023
@patrickhuie19 patrickhuie19 mentioned this pull request Nov 14, 2023
Merged
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from b82377a to 796aac8 Compare November 14, 2023 06:53
krehermann
krehermann reviewed Nov 14, 2023
View reviewed changes
pkg/loop/config.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 14, 2023
View reviewed changes
pkg/loop/telem.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 14, 2023
View reviewed changes
pkg/loop/config.go Outdated Show resolved Hide resolved
@patrickhuie19 patrickhuie19 marked this pull request as ready for review November 15, 2023 03:16
krehermann
krehermann reviewed Nov 15, 2023
View reviewed changes
pkg/config/error.go Outdated Show resolved Hide resolved
jmank88
jmank88 reviewed Nov 15, 2023
View reviewed changes
pkg/loop/telem.go Outdated Show resolved Hide resolved
jmank88
jmank88 previously approved these changes Nov 15, 2023
View reviewed changes
@patrickhuie19 patrickhuie19 force-pushed the feature/tracing-credentials branch from 7320c10 to 0fd90d6 Compare November 15, 2023 19:59
@patrickhuie19 patrickhuie19 merged commit 12d9e48 into main Nov 15, 2023
7 of 8 checks passed
@patrickhuie19 patrickhuie19 deleted the feature/tracing-credentials branch November 15, 2023 20:05
samsondav pushed a commit that referenced this pull request Jan 11, 2024
@patrickhuie19 @samsondav
Wiring through Tracing.TLSCertPath from TOML config (#237)
2ce12d3 
* feature/tracing-credentials: wiring through Tracing.TLSCertPath from TOML config

* feature/tracing-credentials: removing parse of TLSCertPath before SetupTracing

* feature/tracing-credentials: adding ErrIncluded to pkg/config/error.go

* feature/tracing-credentials: lint

* feature/tracing-credentials: removing ErrIncluded to match core
ettec pushed a commit that referenced this pull request Mar 28, 2024
@patrickhuie19 @ettec
Wiring through Tracing.TLSCertPath from TOML config (#237)
9b8c23d 
* feature/tracing-credentials: wiring through Tracing.TLSCertPath from TOML config

* feature/tracing-credentials: removing parse of TLSCertPath before SetupTracing

* feature/tracing-credentials: adding ErrIncluded to pkg/config/error.go

* feature/tracing-credentials: lint

* feature/tracing-credentials: removing ErrIncluded to match core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann left review comments

@jmank88 jmank88 jmank88 approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhuie19 @jmank88 @krehermann