Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-916 PBMC Donor Pooling create plate #1582

Merged
merged 95 commits into from
Mar 11, 2024

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Feb 13, 2024

Closes #

Changes proposed in this pull request

  • scRNA Core Donor Pooling Labware Creator

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@yoldas yoldas linked an issue Feb 13, 2024 that may be closed by this pull request
10 tasks
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.79%. Comparing base (77f7eb1) to head (169891b).
Report is 78 commits behind head on develop.

Files Patch % Lines
lib/tasks/config.rake 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1582      +/-   ##
===========================================
+ Coverage    90.65%   90.79%   +0.14%     
===========================================
  Files          354      358       +4     
  Lines         7273     7411     +138     
===========================================
+ Hits          6593     6729     +136     
- Misses         680      682       +2     
Flag Coverage Δ
javascript 93.62% <ø> (ø)
push 90.79% <98.55%> (+0.14%) ⬆️
ruby 90.39% <98.55%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Mar 11, 2024

Code Climate has analyzed commit 169891b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.3% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@KatyTaylor KatyTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for addressing all those comments!

@yoldas yoldas merged commit 8f38db2 into develop Mar 11, 2024
10 checks passed
@yoldas yoldas deleted the 1390-dpl-916-pbmc-donor-pooling-create-plate branch March 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPL-916 PBMC donor pooling - create plate
3 participants