Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-916 PBMC donor pooling - create plate #1390

Closed
8 of 10 tasks
KatyTaylor opened this issue Sep 25, 2023 · 2 comments · Fixed by #1582, sanger/sequencescape#4057, #1622, #1643 or #1650
Closed
8 of 10 tasks

DPL-916 PBMC donor pooling - create plate #1390

KatyTaylor opened this issue Sep 25, 2023 · 2 comments · Fixed by #1582, sanger/sequencescape#4057, #1622, #1643 or #1650
Assignees
Labels

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Sep 25, 2023

User story
As a user of the scRNA Core pipeline, I would like the LIMS to support the pooling of the PBMCs ready to go on the 10X chip.

Who are the primary contacts for this story
Katy, Lesley, Abby

Who is the nominated tester for UAT
Lesley, Abby

Acceptance criteria
To be considered successful the solution must allow:

  • Input is "LRC PBMC Defrost PBS" plate
  • Output is "LRC PBMC Pools" plate
  • Number of pools (destination wells) determined based on number of source samples, according to [this table]. (https://github.com/sanger/limber/blob/develop/config/cardinal_pooling.csv) Moved to Y24-007
  • Do not allow combining of different studies
  • Do not allow combining of different projects
  • Samples are labelled with 'tag_depth' index to prevent tag clash
  • Requests should be passed and next requests linked up - see 'StateChangers::AutomaticPlateStateChanger'
  • Integration Suite test is updated to include this transfer.
  • TBC - there may be a requirement around collection sites, as with Cardinal, but may not - R&D to check . Moved to Y24-007
  • If samples have the same donor_id they should not be pooled in the same well but can be processed on the same plate.

Assumption

  • Only one chip type is supported in this step.
  • Cell counting data does not affect the target number of pools / donors per pool for this step.
  • There may be an additional constraint to generate even number of pools, but this is not relevant to new GEM-X chip.

Additional information
Probably useful to look at the equivalent step in the Cardinal pipeline:

  • Documentation here
  • See class CardinalPoolsPlate

Validation around studies and projects is because:

  • Combining studies can be risky from a data protection point of view
  • We have been told it is not intended
  • There is equivalent validation at the point of creation of compound samples (just prior to sequencing), so we don't want to allow it now if it will be rejected then
  • Each pool (compound sample) will be represented by just one study and project (= cost code) in the iseq_flowcell table in the MLWH
@KatyTaylor KatyTaylor changed the title DPL-916 Pool PBMCs based on cell count DPL-916 DPL-1024 PBMC donor pooling - transfer Dec 11, 2023
@KatyTaylor KatyTaylor changed the title DPL-916 DPL-1024 PBMC donor pooling - transfer DPL-916 DPL-1024 PBMC donor pooling - create plate Dec 11, 2023
@KatyTaylor KatyTaylor added the Size: M Medium - medium effort & risk label Dec 12, 2023
@KatyTaylor KatyTaylor changed the title DPL-916 DPL-1024 PBMC donor pooling - create plate DPL-916 PBMC donor pooling - create plate Feb 5, 2024
@yoldas yoldas self-assigned this Feb 11, 2024
@yoldas yoldas linked a pull request Feb 13, 2024 that will close this issue
@yoldas
Copy link
Member

yoldas commented Feb 23, 2024

Until we have a new lookup table to map number of samples to number of pools, I am using a copy of the cardinal table, which covers number of samples up to 96. From 97 to 160 samples, I am using 16 pools for now. (We could extrapolate it to roughly 10-11 samples per pool but I will wait for a new lookup table).

FYI, attached image that shows the pattern for the number of pools up to 96 samples. Labels show at which number of samples, the number of pools changes, for example 76 samples => 6 pools, 77 samples => 7 pools.

number_of_samples_vs_number_of_pools

@yoldas
Copy link
Member

yoldas commented Mar 26, 2024

The integration suite GitLab Merge Request was at https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/119 . I removed the card from project board to reduce the clutter. I am linking here instead.

They are now merged into the scrna_core_pipeline branch. MR: Draft: scRNA Core, Phase 2

It misses a check for driver file download and we do not have the pools input scenario yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment