Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL-916 PBMC Donor Pooling create plate #1582
DPL-916 PBMC Donor Pooling create plate #1582
Changes from 13 commits
aceec0e
9f2313f
e5c7d03
bac22b6
a23b111
e1a4003
d92ae65
a6726d2
fa56710
dcccca8
dd1033b
f8483ac
cb5599e
529cace
2e0a199
3d96ccf
05de79a
acc4d5c
8279d4d
c4287ba
1ebd41b
9afc083
9988999
60fbf63
7421274
0aebf5c
71b9c70
c1fd115
de63cdb
7e957e1
81e71a9
6b791e3
f84278c
37b5db7
580e4b7
52dd3c5
b3bbe22
96a79e3
4c97d08
c2fbbaa
d35641d
2d9f022
616f4c4
d5cdca5
c8ffdb9
05bd224
c74e242
bd90134
d484671
61ec788
7acfec8
a3fda01
407f630
698d887
127c487
89045f9
649eb89
595b8cb
542c209
75f0db3
2ca3b52
58f224d
08bd157
c312ead
b491741
37e3b6a
f209901
2a89e43
7bc4277
254c788
918f710
4440b33
a4c43cf
7ed1788
3bb5088
a815052
67693fe
e8dbe18
ec22680
68b1e83
80b1bea
7224c0d
d02883c
711ac1c
9d08807
4ce1bcc
4386930
efc8360
f458b48
8590d76
651445c
fe38028
e3960c4
169891b
d4b8573
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this number be coming from the purpose config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have removed the constant and added it as argument to the labware creator in the purpose config.
Check warning on line 49 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L49
Check warning on line 59 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L59
Check warning on line 66 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L66
Check warning on line 73 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L73
Check warning on line 82 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L82
Check warning on line 89 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L89
Check warning on line 99 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L98-L99
Check warning on line 108 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L108
Check warning on line 118 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L117-L118
Check warning on line 122 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L122
Check warning on line 133 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L132-L133
Check warning on line 146 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L146
Check warning on line 159 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L159
Check warning on line 161 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L161
Check warning on line 175 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L175
Check warning on line 183 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L183
Check warning on line 187 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L186-L187
Check warning on line 200 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L199-L200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats this comment referring to? is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was referring to 1-based index but not obvious. I have already removed this method to address another comment.
Check warning on line 213 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L211-L213
Check warning on line 223 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L223
Check warning on line 234 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L234
Check warning on line 249 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L244-L249
Check warning on line 251 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L251
Check warning on line 253 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L253
Check warning on line 262 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L262
Check warning on line 275 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L272-L275
Check warning on line 277 in app/models/labware_creators/donor_pooling_plate.rb
Codecov / codecov/patch
app/models/labware_creators/donor_pooling_plate.rb#L277