Allow specifying qos #1225
Merged
Allow specifying qos #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloretz
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Mind updating the test too? Looks like it's failing on the PR job. I'd recommend making the test use keyword args instead
rclpy/rclpy/test/test_wait_for_message.py
Line 60 in 220d714
Signed-off-by: Tim Clephas <[email protected]>
Signed-off-by: Tim Clephas <[email protected]>
Timple
force-pushed
the
wait-for-message-qos
branch
from
8d68061
to
bdc1198
Compare
Signed-off-by: Tim Clephas <[email protected]>
Timple
force-pushed
the
wait-for-message-qos
branch
from
9bdeb1c
to
2bbe554
Compare
fujitatomoya
approved these changes
Mar 25, 2024
|
CI:
|
|
FYI, there are some flake8 errors associated with this PR (they are a little hidden because of other, unrelated flake8 errors, but here is a direct link: https://ci.ros2.org/job/ci_linux/20558/testReport/junit/rclpy/flake8/I100____test_test_wait_for_message_py_21_1_/) |
Signed-off-by: Tim Clephas <[email protected]>
Timple
force-pushed
the
wait-for-message-qos
branch
from
ac67ad3
to
c46bbea
Compare
|
Thank you @clalancette that was indeed snowed under. Thanks for the pointer, fixed now. |
Thanks. The other flake8 errors should be fixed now, so the next CI run should be clean:
|
|
@Mergifyio backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
* Allow specifying qos Signed-off-by: Tim Clephas <[email protected]> (cherry picked from commit 34cfd2f)
fujitatomoya
pushed a commit
to fujitatomoya/rclpy
that referenced
this pull request
Apr 22, 2024
* Allow specifying qos Signed-off-by: Tim Clephas <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Jun 25, 2024
* Add feature of wait for message (#953). (#960) * Add feature of wait for message. Signed-off-by: Lei Liu <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> * Fix to issue #1179 (#1180) * Fix to issue #1179 Signed-off-by: KKSTB <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> * Allow specifying qos (#1225) * Allow specifying qos Signed-off-by: Tim Clephas <[email protected]> --------- Signed-off-by: Lei Liu <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: KKSTB <[email protected]> Signed-off-by: Tim Clephas <[email protected]> Co-authored-by: Lei Liu <[email protected]> Co-authored-by: KKSTB <[email protected]> Co-authored-by: Tim Clephas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function didn't work for transient local publishers.
This is a breaking change because the argument order is changed. However with the future in mind, this order makes most sense to me as all first arguments are passed directly to the subscription.
If you like the original order I can change this.