Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying qos (backport #1225) #1274

Open
wants to merge 1 commit into
base: iron
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2024

This function didn't work for transient local publishers.

This is a breaking change because the argument order is changed. However with the future in mind, this order makes most sense to me as all first arguments are passed directly to the subscription.

If you like the original order I can change this.


This is an automatic backport of pull request #1225 done by Mergify.

* Allow specifying qos

Signed-off-by: Tim Clephas <[email protected]>
(cherry picked from commit 34cfd2f)
@mergify mergify bot mentioned this pull request Apr 22, 2024
@fujitatomoya
Copy link
Collaborator

@Timple just FYI, this is the backport of #1225 for iron. i will cherry-pick this to #1272.

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants