Enforce keyword arguments, add typing

Signed-off-by: Tim Clephas <[email protected]>
ros2 · Feb 27, 2024 · bdc1198 · bdc1198
1 parent 63dceed
commit bdc1198
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/rclpy/rclpy/wait_for_message.py b/rclpy/rclpy/wait_for_message.py
@@ -12,8 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from typing import Union
+
 from rclpy.impl.implementation_singleton import rclpy_implementation as _rclpy
 from rclpy.node import Node
+from rclpy.qos import QoSProfile
 from rclpy.signals import SignalHandlerGuardCondition
 from rclpy.utilities import timeout_sec_to_nsec
 
@@ -22,7 +25,8 @@ def wait_for_message(
  msg_type,
  node: 'Node',
  topic: str,
- qos_profile = 1,
+ *,
+ qos_profile: Union[QoSProfile, int] = 1,
  time_to_wait=-1
 ):
  """

diff --git a/rclpy/test/test_wait_for_message.py b/rclpy/test/test_wait_for_message.py
@@ -57,7 +57,7 @@ def test_wait_for_message(self):
  t.join()
 
  def test_wait_for_message_timeout(self):
- ret, _ = wait_for_message(BasicTypes, self.node, TOPIC_NAME, 1)
+ ret, _ = wait_for_message(BasicTypes, self.node, TOPIC_NAME, time_to_wait=1)
  self.assertFalse(ret)