[JTC] Remove start_with_holding option (backport #839)

[mergify]

This is an automatic backport of pull request #839 done by Mergify.

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b6558d1) 47.70% compared to head (622965c) 47.03%.
Report is 16 commits behind head on iron.

❗ Current head 622965c differs from pull request most recent head 8c6f19d. Consider uploading reports for the commit 8c6f19d to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             iron     #876      +/-   ##
==========================================
- Coverage   47.70%   47.03%   -0.67%     
==========================================
  Files          40       40              
  Lines        3664     3663       -1     
  Branches     1739     1738       -1     
==========================================
- Hits         1748     1723      -25     
- Misses        712      736      +24     
  Partials     1204     1204              

Flag	Coverage Δ
unittests	47.03% <0.00%> (-0.67%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp	47.26% <0.00%> (-0.21%)	⬇️

... and 2 files with indirect coverage changes

[bmagyar]

I think it may be a little too late for thjis feature to go into Iron

[christophfroehlich]

I think it may be a little too late for thjis feature to go into Iron

As you prefer. But then I'd add a deprecation warning?

[bmagyar]

Yes please add a deprecation warning instead. I'll close this PR in the mean time