Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted rqt_jtc to newest control_msgs for jtc (backport #643) #659

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 11, 2023

This is an automatic backport of pull request #643 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@bmagyar
Copy link
Member

bmagyar commented Jun 11, 2023

I bumped into the same issue on humble today I think... @destogl how about you?

@bmagyar bmagyar closed this Aug 5, 2023
@mergify mergify bot deleted the mergify/bp/humble/pr-643 branch August 5, 2023 09:34
@christophfroehlich
Copy link
Contributor

christophfroehlich commented Dec 7, 2023

Maybe to add a note that RQT plugin is using only new topic because we want people using humble to transition to the new one

Originally posted by @destogl in #642 (comment)

What I understood is that humble was supposed to handle both, so we should not break RQT_JTC there. But now RQT_JTC is broken in rolling because in rolling there is only one topic accepted and one type of msg accepted.

Originally posted by @gwalck in #642 (comment)

Currently, using rqt_jtc with humble will work but JTC will output a warning because there is a subscriber to the old topic.
If we backport this, nothing will be broken and no warning will be given any more?

@destogl
Copy link
Member

destogl commented Dec 7, 2023

@christophfroehlich, should we reopen this?

@christophfroehlich christophfroehlich restored the mergify/bp/humble/pr-643 branch December 7, 2023 16:29
@christophfroehlich
Copy link
Contributor

@christophfroehlich, should we reopen this?

let's reopen this! @saikishor is working on a fix of rqt_jtc with continuous joints, with the backport we'll be able to backport future fixes too

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #659 (f00c8ab) into humble (6ca4026) will increase coverage by 0.40%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble     #659      +/-   ##
==========================================
+ Coverage   44.81%   45.21%   +0.40%     
==========================================
  Files          40       40              
  Lines        3713     3713              
  Branches     1769     1769              
==========================================
+ Hits         1664     1679      +15     
+ Misses        835      820      -15     
  Partials     1214     1214              
Flag Coverage Δ
unittests 45.21% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit 8dfc247 into humble Dec 10, 2023
13 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-643 branch December 10, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants