[ForceTorqueSensorBroadcaster] added force and torque offsets to the parameters + export state interfaces #1215
+202
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
jaron-l,
mcbed,
moriarty,
peterdavidfagan and
VX792
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 80.34% 80.45% +0.11%
==========================================
Files 105 105
Lines 9385 9457 +72
Branches 827 836 +9
==========================================
+ Hits 7540 7609 +69
- Misses 1570 1571 +1
- Partials 275 277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
changed the title
saikishor
changed the title
bmagyar
reviewed
Aug 15, 2024
Comment on lines
224
to
229
| msg.wrench.force.x -= params.offset.force.x; | ||
| msg.wrench.force.y -= params.offset.force.y; | ||
| msg.wrench.force.z -= params.offset.force.z; | ||
| msg.wrench.torque.x -= params.offset.torque.x; | ||
| msg.wrench.torque.y -= params.offset.torque.y; | ||
| msg.wrench.torque.z -= params.offset.torque.z; |
There was a problem hiding this comment.
I don't want to be a nag but I'd reeeeeeeally expect offsets to be added using a +
There was a problem hiding this comment.
A very very fair point!
I'll try to change it ASAP
There was a problem hiding this comment.
Done. I've made the changes. Thanks for the feedback
|
Rebased the PR! :) |
…sensor_broadcaster
…xpose interfaces removing the offsets
saikishor
force-pushed
the
add/offsets/force_torque_sensor_broadcaster
branch
from
4bab5f6
to
f7643ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to define of the offsets of the force and torque through the parameter server. It would also be interesting to make it a chainable controller and expose the interfaces to the other controllers.
Now the offsets are removed and published and the same interfaces are exposed as state interfaces to be able to chain by other controllers