-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ForceTorqueSensorBroadcaster] added force and torque offsets to the parameters + export state interfaces #1215
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 80.34% 80.45% +0.11%
==========================================
Files 105 105
Lines 9385 9457 +72
Branches 827 836 +9
==========================================
+ Hits 7540 7609 +69
- Misses 1570 1571 +1
- Partials 275 277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
msg.wrench.force.x -= params.offset.force.x; | ||
msg.wrench.force.y -= params.offset.force.y; | ||
msg.wrench.force.z -= params.offset.force.z; | ||
msg.wrench.torque.x -= params.offset.torque.x; | ||
msg.wrench.torque.y -= params.offset.torque.y; | ||
msg.wrench.torque.z -= params.offset.torque.z; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to be a nag but I'd reeeeeeeally expect offsets to be added using a +
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very very fair point!
I'll try to change it ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I've made the changes. Thanks for the feedback
Rebased the PR! :) |
…sensor_broadcaster
…xpose interfaces removing the offsets
4bab5f6
to
f7643ba
Compare
This PR allows to define of the offsets of the force and torque through the parameter server. It would also be interesting to make it a chainable controller and expose the interfaces to the other controllers.
Now the offsets are removed and published and the same interfaces are exposed as state interfaces to be able to chain by other controllers