Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Eigen CMake target #1058

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

I changed the CMake file to use Eigen's CMake target as described here https://eigen.tuxfamily.org/dox/TopicCMakeGuide.html

See ros-controls/control_toolbox#178 for the issues with RHEL 8.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 25, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.16%. Comparing base (9f7e9e9) to head (7f14732).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1058       +/-   ##
===========================================
+ Coverage   47.71%   72.16%   +24.44%     
===========================================
  Files          41       41               
  Lines        3871     3639      -232     
  Branches     1833     1781       -52     
===========================================
+ Hits         1847     2626      +779     
+ Misses        751      700       -51     
+ Partials     1273      313      -960     
Flag Coverage Δ
unittests 72.16% <ø> (+24.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for using modern CMake :-)

@bmagyar bmagyar merged commit 7d38fb9 into ros-controls:master Mar 1, 2024
16 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Mar 1, 2024
(cherry picked from commit 7d38fb9)
mergify bot pushed a commit that referenced this pull request Mar 1, 2024
(cherry picked from commit 7d38fb9)
bmagyar pushed a commit that referenced this pull request Mar 2, 2024
bmagyar pushed a commit that referenced this pull request Mar 2, 2024
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants