Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] debian + RHEL updates (backport #985) and remove EOL workflows #1016

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 5, 2024

This is an automatic backport of pull request #985 done by Mergify.
Cherry-pick of 0bcb77b has failed:

On branch mergify/bp/humble/pr-985
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 0bcb77b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .github/workflows/humble-debian-build.yml
	modified:   .github/workflows/humble-rhel-binary-build.yml
	new file:   .github/workflows/iron-debian-build.yml
	new file:   .github/workflows/rolling-debian-build.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/galactic-rhel-binary-build.yml
	both modified:   .github/workflows/rolling-rhel-binary-build.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 0bcb77b)

# Conflicts:
#	.github/workflows/galactic-rhel-binary-build.yml
#	.github/workflows/rolling-rhel-binary-build.yml
@mergify mergify bot added the conflicts label Feb 5, 2024
@bmagyar
Copy link
Member

bmagyar commented Feb 5, 2024

Format complains

@christophfroehlich
Copy link
Contributor

Format complains

because of merge conflicts. I'll fix that

@christophfroehlich
Copy link
Contributor

Fixed. I also removed the foxy and galactic workflows at all, because it generated a merge conflict here?

@christophfroehlich christophfroehlich changed the title [CI] debian + RHEL updates (backport #985) [CI] debian + RHEL updates (backport #985) and remove EOL workflows Feb 5, 2024
@bmagyar
Copy link
Member

bmagyar commented Feb 7, 2024

wasn't generate parameter library available in RHEL already?

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (73282d9) 47.25% compared to head (1cda337) 46.77%.
Report is 9 commits behind head on humble.

❗ Current head 1cda337 differs from pull request most recent head 68021c5. Consider uploading reports for the commit 68021c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1016      +/-   ##
==========================================
- Coverage   47.25%   46.77%   -0.49%     
==========================================
  Files          40       40              
  Lines        3722     3731       +9     
  Branches     1780     1794      +14     
==========================================
- Hits         1759     1745      -14     
- Misses        723      738      +15     
- Partials     1240     1248       +8     
Flag Coverage Δ
unittests 46.77% <31.25%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...roadcaster/src/force_torque_sensor_broadcaster.cpp 59.70% <50.00%> (-0.91%) ⬇️
...ory_controller/src/joint_trajectory_controller.cpp 46.46% <25.00%> (-0.22%) ⬇️

... and 3 files with indirect coverage changes

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Feb 7, 2024

wasn't generate parameter library available in RHEL already?

I originally thought it was released for RHEL 8, this is why I forgot to add the sourcing of the underlay to the humble workflow. should be fixed now

@bmagyar bmagyar merged commit c950730 into humble Feb 9, 2024
9 of 14 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-985 branch February 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants