Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link to hardware_components #1009

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented May 4, 2023

Fix the link to the hardware_components documentation to a working version.

The link that was there is obviously dead. I'm not sure whether linking to the master version is the correct solution to handle this, but at least it works.

Fix the link to the hardware_components documentation to a working version.
Co-authored-by: Christoph Fröhlich <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1009 (c976b56) into master (925f5f3) will decrease coverage by 1.93%.
The diff coverage is 35.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
- Coverage   34.61%   32.69%   -1.93%     
==========================================
  Files          52       91      +39     
  Lines        2981     9551    +6570     
  Branches     1855     6432    +4577     
==========================================
+ Hits         1032     3123    +2091     
- Misses        310      704     +394     
- Partials     1639     5724    +4085     
Flag Coverage Δ
unittests 32.69% <35.61%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.27% <ø> (-1.44%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much much better sir, thanks!

@bmagyar bmagyar merged commit cb92c50 into ros-controls:master May 5, 2023
1 check passed
@bmagyar
Copy link
Member

bmagyar commented May 5, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 5, 2023
* Fix link to hardware_components

Fix the link to the hardware_components documentation to a working version.

* use sphinx ref

Co-authored-by: Christoph Fröhlich <[email protected]>

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit cb92c50)
bmagyar pushed a commit that referenced this pull request May 5, 2023
* Fix link to hardware_components

Fix the link to the hardware_components documentation to a working version.

* use sphinx ref

Co-authored-by: Christoph Fröhlich <[email protected]>

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit cb92c50)

Co-authored-by: Felix Exner (fexner) <[email protected]>
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
…ls#1011)

* Fix link to hardware_components

Fix the link to the hardware_components documentation to a working version.

* use sphinx ref

Co-authored-by: Christoph Fröhlich <[email protected]>

---------

Co-authored-by: Christoph Fröhlich <[email protected]>
(cherry picked from commit cb92c50)

Co-authored-by: Felix Exner (fexner) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants