-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update codeUtil.ts to download vscode for linux-arm64 #1161
Conversation
Quality Gate passedIssues Measures |
based on #1090 Thank you for you initial PR @timimichr . I am adding this one to include this in next release ASAP. |
Do you have any estimate on when it can be solved regarding the chromedrivers as well? |
what exactly do you mean? |
In the draft PR: https://github.com/redhat-developer/vscode-extension-tester/pull/1090/files While this PR, that is now merged and in the latest release, makes the package download correct vscode for linux arm it still downloads x64 chromedrivers. See logs:
Am only running this on a Linux Arm machine in a pipeline, which makes it a bit harder to debug for me. But I believe this is the reason that the extension later fails to run the vscode-browser. |
yes right, thanks for reminding me. It would require a lot more work because as you mentioned in PR comment near suggested solution there needs to be dynamic version set based on electron version used by VS Code version. and then used that one only for linux arm64 platform.. or do complete switch from Chrome for testing to Electron Chromedriver which would require even much more work currently but you are right.. I have missed it won't work from scratch because it will download right version of VS Code for linux arm but not the correct platform version of chromedriver (which is not available at all currently at Chrome for testing side 🙁 ) I would ask you to open new issue directly for supporting linux arm64 driver and we can take a look further later.. if you would be interested to provide more complex fix for it maybe? btw macos arm should be supported already for vscode and chromedriver |
opened tracker on side of chrome for testing regarding missing chromedriver binaries for Linux ARM - GoogleChromeLabs/chrome-for-testing#1 |
Continue the conversation here instead of opening an issue directly, so the issue can be properly formulated. Since the chromedriver is not available on Chrome yet, would it be possible to add a function that allows the user to set url of the chromedriver download link themself. In the POC PR I open, I had a hard coded url that links to linux arm chromedrivers. But it seemed as if either codeUtil_1 or driverUtil_1 (IIRC) got re-initiated at some time during the execution time as well. And this caused the run not to find the chromedriver. This re-initialisation cause it to look at the "default" path again, because it was not re-initialized from the ExTester instance that I had created with my overrides. But it might also be possible that even if it looked at the desired chromedriver (set by me) it would fail. I have to little knowledge of the different chrome drivers to know. I hope this make sense. |
@timimichr ok I follow your thoughts. I think it should be possible but I fear it still would need kinda lot of work and basically imho I feel to make it easy maintainable we would need to rework current implementation because there are two options currently how to achieve desired
but basically both needs to solve first the matching logic for electron versions which would ve desired VS Code built on.. another story would be to make it nice and easy by extracting managing driver logic to separate package which would be then possible to parametrise and more easily modify to these changes which then just reused for ExTester (which is btw plan anyway for some unseen future now unfortunately)... sooo long story short.. it is possible but it depends |
Before submitting your PR, please review the following checklist:
Before merging the PR:
main
branch is green.