Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚫 Bug] Download vscode and chromedriver on linux arm targets wrong version of both #1089

Closed
timimichr opened this issue Jan 19, 2024 · 0 comments · Fixed by #1161
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@timimichr
Copy link
Contributor

Describe the bug

While running a pipeline that uses linux arm64 I noticed that the vs-code that gets downloaded is target with os "linux-ia32" and that the chromedriver is targeted with os "linux64". And for vscode linux-ia32 it gets reported as 404 not found.
View logs too see the urls with the faulty target platforms.

Will need to change getPlatform in codeUtil.js to something like:
if (platform === 'linux') { platform += arch === 'x64' || arch === 'arm64' ? -${arch}:-ia32; }

For the chromedriver a change to target a different root url is needed since https://chromedriver.storage.googleapis.com do not have chromedrivers for linux-arm64.
I used this link to create a work around: "https://github.com/electron/electron/releases/download/v25.3.1/chromedriver-v25.3.1-linux-arm64.zip" for when targeting vscode version 1.85.0.
But would need to create a mapping between vscode versions and which version to target from https://github.com/electron/electron/releases/ if desired to have it more dynamic.

Steps to reproduce

1. Use linux arm64 os
2. Execute ExTester.setupAndRunTests or exTester.setupRequirements()

Logs

Downloading vscode logs:
Downloading VS Code: 1.85.1 / stable
Downloading VS Code from: https://update.code.visualstudio.com/1.85.1/linux-ia32/stable
progress: 0/9 (0%)
file:///home/circleci/project/node_modules/got/dist/source/core/index.js:706
            this._beforeError(new HTTPError(typedResponse));
                              ^
HTTPError: Response code 404 (Not Found)



Downloading chrome driver logs:
Downloading ChromeDriver 114.0.5735.90 from: https://chromedriver.storage.googleapis.com/114.0.5735.90/chromedriver_linux64.zip
progress: 0/7407250 (0%)
progress: 7407250/7407250 (100%)
Unpacking ChromeDriver 114.0.5735.90 into /home/circleci/project/test/test-resources
Success!
Executing prepublish script 'npm run vscode:prepublish'...

Operating System

linux arm64

Visual Studio Code

1.85.1

vscode-extension-tester

7.0.0

NodeJS

v16.17.0

npm

@timimichr timimichr added bug Something isn't working new-issue New issue which was not discussed yet labels Jan 19, 2024
@timimichr timimichr mentioned this issue Jan 19, 2024
9 tasks
@djelinek djelinek added this to ExTester Feb 5, 2024
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Feb 7, 2024
@djelinek djelinek moved this from New to In Progress in ExTester Feb 7, 2024
@djelinek djelinek added this to the NEXT milestone Feb 7, 2024
@djelinek djelinek linked a pull request Feb 9, 2024 that will close this issue
9 tasks
@djelinek djelinek linked a pull request Feb 27, 2024 that will close this issue
9 tasks
@djelinek djelinek modified the milestones: NEXT, 7.2.0 Feb 27, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in ExTester Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
2 participants