-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for linux-arm64 #1090
Support for linux-arm64 #1090
Conversation
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Bug report: #1089 |
Hello @timimichr , thank you for your PR! You have spotted good points we are missing in our codebase. Regarding your solution you have provided. I think we should split into to separate issues:
|
@@ -361,7 +361,7 @@ export class CodeUtil { | |||
this.cliEnv = 'ELECTRON_RUN_AS_NODE=1'; | |||
|
|||
if (platform === 'linux') { | |||
platform += arch === 'x64' ? `-${arch}` : `-ia32`; | |||
platform += arch === 'x64' || arch === 'arm64' ? `-${arch}` : `-ia32`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest reverse approach when checking the arch
platform += arch === 'ia32' ? '-ia32' : `-${arch}`;
will be handled by #1161 |
Before submitting your PR, please review the following checklist:
Before merging the PR:
main
branch is green.