Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for linux-arm64 #1090

Closed
wants to merge 2 commits into from
Closed

Conversation

timimichr
Copy link
Contributor

@timimichr timimichr commented Jan 19, 2024

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@timimichr
Copy link
Contributor Author

Bug report: #1089

@djelinek
Copy link
Collaborator

djelinek commented Feb 9, 2024

Hello @timimichr , thank you for your PR!

You have spotted good points we are missing in our codebase. Regarding your solution you have provided. I think we should split into to separate issues:

  1. support linux arm for VS Code binary downloads
  2. support linux arm for chromedriver - that one will need a lot more work and complex implementation, to investigate possibilities how to bring maybe electron chromedriver into project (see [🚀 Request] Investigate Electron Chromedriver node module #1118 )

@@ -361,7 +361,7 @@ export class CodeUtil {
this.cliEnv = 'ELECTRON_RUN_AS_NODE=1';

if (platform === 'linux') {
platform += arch === 'x64' ? `-${arch}` : `-ia32`;
platform += arch === 'x64' || arch === 'arm64' ? `-${arch}` : `-ia32`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest reverse approach when checking the arch

platform += arch === 'ia32' ? '-ia32' : `-${arch}`;

@djelinek djelinek added the rebase-required Conflicts with main branch, need to rebase label Feb 9, 2024
@djelinek
Copy link
Collaborator

will be handled by #1161

@djelinek djelinek closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebase-required Conflicts with main branch, need to rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] Download vscode and chromedriver on linux arm targets wrong version of both
2 participants