feat: add v2prov kubeconfig label patching #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
4 tasks
4 tasks
richardcase
force-pushed
the
patch_v2prov_secrets
branch
2 times, most recently
from
1ebd4c8
to
74e00a4
Compare
richardcase
changed the title
richardcase
force-pushed
the
patch_v2prov_secrets
branch
from
65f64db
to
2b2ae5a
Compare
alexander-demicev
previously approved these changes
Oct 10, 2023
richardcase
force-pushed
the
patch_v2prov_secrets
branch
2 times, most recently
from
94380bd
to
0d2aee3
Compare
This change adds a controller that watches for v2prov kubeconfig secrets. It will then add the owned label (if it doesn't exist) as this is required by CAPI 1.5.0 and higher. It has been added as a feature that needs to be enabled so that we can disable it in the future when the changes in Rancher have merged and are generally available. Additionally, this adds a new test suite that ensure that the Rancher label patcher work and that a v2prov cluster can be provisined with CAPI 1.5.x. In the future we can use this test to ensure we don't break v2prov instead of the existing test. Although the current test is done against the HEAD version of Rancher which is valuable. Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
patch_v2prov_secrets
branch
from
0d2aee3
to
69861d0
Compare
alexander-demicev
previously approved these changes
Oct 10, 2023
Signed-off-by: Richard Case <[email protected]>
furkatgofurov7
previously approved these changes
Oct 11, 2023
Signed-off-by: Richard Case <[email protected]>
Signed-off-by: Richard Case <[email protected]>
salasberryfin
approved these changes
Oct 11, 2023
charts/rancher-turtles/templates/rancher-turtles-components.yaml
Outdated
Show resolved
Hide resolved
Danil-Grigorev
approved these changes
Oct 11, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds a controller that watches for v2prov kubeconfig secrets. It will then add the owned label (if it doesn't exist) as this is required by CAPI 1.5.0 and higher.
It has been added as a feature that needs to be enabled so that we can disable it in the future when the changes in Rancher have merged and are generally available.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #179
Special notes for your reviewer:
This adds a new e2e test suite that is very similar to the existing
v2provsuite. In time we would consider making this new suite the test for v2prov....when we bump CAPI to v1.5.x in all our tests.Checklist: