🌱 Apply embedded capi feature flag after rancher install #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
2 times, most recently
from
64d7c87
to
dd50762
Compare
alexander-demicev
previously approved these changes
Oct 4, 2023
|
will this fail e2e until webhooks are fixed in rancher? |
Yes, until the implementation part is done the e2e tests would fail to apply CAPI cluster with this coming from fleet logs: |
|
Until we have that feature in Rancher turtles we can always use RunCommand to run the following after disabling the feature and waiting for the Rancher CAPI deployment to be removed: kubectl delete mutatingwebhookconfigurations.admissionregistration.k8s.io mutating-webhook-configuration
kubectl delete validatingwebhookconfigurations.admissionregistration.k8s.io validating-webhook-configuration |
|
Or we just wait for the feature to be added 😉 |
|
@richardcase should we have a controller temporarily like this one #178 to require less setup from users? |
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
2 times, most recently
from
ba09e24
to
b95cdac
Compare
4 tasks
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
2 times, most recently
from
8c1a90e
to
fb82b51
Compare
salasberryfin
previously approved these changes
Oct 5, 2023
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
from
fb82b51
to
38406d1
Compare
salasberryfin
previously approved these changes
Oct 6, 2023
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
from
38406d1
to
5b7e80e
Compare
alexander-demicev
previously approved these changes
Oct 9, 2023
salasberryfin
previously approved these changes
Oct 9, 2023
Danil-Grigorev
dismissed stale reviews from salasberryfin and alexander-demicev
via
c2b3d07
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
from
5b7e80e
to
c2b3d07
Compare
Signed-off-by: Danil Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
apply-fg-after-rancher-setup
branch
from
c2b3d07
to
3a70bf3
Compare
alexander-demicev
approved these changes
Oct 9, 2023
salasberryfin
approved these changes
Oct 9, 2023
Danil-Grigorev
added a commit
to Danil-Grigorev/rancher-turtles
that referenced
this pull request
Oct 9, 2023
Signed-off-by: Danil Grigorev <[email protected]>
Danil-Grigorev
added a commit
to Danil-Grigorev/rancher-turtles
that referenced
this pull request
Oct 9, 2023
Signed-off-by: Danil Grigorev <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/chore
What this PR does / why we need it:
This PR converts all existing gitops scenarios to a rancher installation with post-install step applying required feature gates as per documented installation process.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #188
Special notes for your reviewer:
Checklist: