-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable 'rancher-kubeconfigs' feature gate in charts #663
Conversation
Signed-off-by: Furkat Gofurov <[email protected]>
'rancher-kubeconfigs' FG was introduced to test CAPI >=v1.5.x in turtles at the time Rancher was not ready. However with newer Rancher version it should be possible to test newer version of CAPI without this FG. Moreover, update-labels suite tests FG by explicitly setting it to true, but by default we should not expose it as enabled in charts Signed-off-by: Furkat Gofurov <[email protected]>
@furkatgofurov7 After thinking about I’m under the impression we need to do the opposite of what this PR suggests. Always apply label on the secrets, and never disable it. Unless there is a confidence that existing rancher code performs this task instead of turtles already. If you have a link, then it lgtm |
@Danil-Grigorev here you go:
|
@alexander-demicev what are your thoughts on this, do you foresee any problems with disabling this FG by default? |
@furkatgofurov7 It should be fine to disable it |
What this PR does / why we need it:
'rancher-kubeconfigs' FG introduced in #178 was meant to test CAPI >=v1.5.x in turtles at the time Rancher was not ready yet. However, with the newer Rancher version (v2.9.x using CAPI v1.7.x) it should be possible to test newer version of CAPI without this feature gate enabled. Moreover,
update-labels
test suite this FG by explicitly setting it to true anyways, but by default we should not expose it as enabled in charts.Additionally, it is a follow-up to #658 to bump leftover dependencies to newer versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: