Check that favicons are present and up-to-date #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this would close r-lib/usethis#1995 + supersede r-lib/usethis#1996? |
maelle
approved these changes
May 31, 2024
Co-authored-by: Maëlle Salmon <[email protected]>
|
@olivroy totally forgot about that issue + PR. Do you agree that it makes more sense to alert here instead of usethis? |
olivroy
reviewed
May 31, 2024
This was referenced May 31, 2024
Co-authored-by: olivroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maelle @jayhesselberth do you think this is too aggressive? From experience, I do know it is easy to forget to update the favicons when you update your logo.