Nudge towards building favicons in use_logo() and use_pkgdown()
#1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
commented
May 23, 2024
| ) | ||
| } | ||
|
|
||
| potentially_has_logo <- function() { |
There was a problem hiding this comment.
This idea came to me, because of PRs I opened in various repos of package devs who didn't seem to be aware of this. see #1995
|
Nice idea! I think you could just run the code if openssl was installed (which I suspect will be the most common case). |
|
I just realized that pkgdown is not a usethis dependency, so running the code may cause R CMD CHECK issues after all.. |
|
r-lib/pkgdown#2611 is a better solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1995.
I think usethis could run it automatically, but since
build_favicons()has an openssl dependency, it may better to let users do it.Over time, I have encountered many examples of packages that don't use the standard man/figures/logo.png that pkgdown recognizes.
With r-lib/pkgdown#2563, they will no longer be built automatically on gh actions, so they have to be initialized manually by users.
cc: @hadley if you have some views of what should happen here!