Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use_logo() call or suggest pkgdown::build_favicons()? #1995

Closed
olivroy opened this issue May 23, 2024 · 1 comment
Closed

Should use_logo() call or suggest pkgdown::build_favicons()? #1995

olivroy opened this issue May 23, 2024 · 1 comment

Comments

@olivroy
Copy link
Contributor

olivroy commented May 23, 2024 •
edited
Loading

In the wild, I noted that many packages have a logo in their package, but it is not recognized by usethis/pkgdown because the file is not named man/figures/logo.png

Examples of PRs I opened in various repos to address this.

The idea is that one can never build_site() locally and still have a running website, as use_pkgdown_github_actions() does that. However, as of pkgdown 2.1, favicons will no longer be built on CI.

Update from #844 + r-lib/pkgdown#2563
@olivroy olivroy mentioned this issue May 23, 2024
Closed
@olivroy olivroy mentioned this issue May 31, 2024
Merged
@olivroy
Copy link
Contributor Author

olivroy commented May 31, 2024

r-lib/pkgdown#2611 is a better solution!

@olivroy olivroy closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nudge towards building favicons in use_logo() and use_pkgdown() olivroy/usethis
1 participant
@olivroy