Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OpenTracing modules due to unreleased extensions in Quarkiverse #1519

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 15, 2023

Summary

Extensions are moved quarkusio/quarkus#36602 but as for now, not released:

Usage in Build Time Analytics won't cause compilation failure for whole TS and I'll handle it in a separate PR - https://github.com/quarkus-qe/quarkus-test-suite/blob/main/build-time-analytics/src/test/java/io/quarkus/ts/buildtimeanalytics/AnalyticsUtils.java#L95 as there it will be replacement with OTEL.

See: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan
Copy link
Contributor

It looks good to me module's lines are commented by the moment but let's wait CI jobs pass and then merge it

@michalvavrik
Copy link
Member Author

It looks good to me module's lines are commented by the moment but let's wait CI jobs pass and then merge it

Thanks, I expect Kafka failures (see other PR where you are reviewer) and now I mentioned that https://github.com/quarkus-qe/quarkus-test-suite/blob/main/build-time-analytics/src/test/java/io/quarkus/ts/buildtimeanalytics/AnalyticsUtils.java#L95 also points to this extension, but it only means one test failure and won't block other PRs. I'll create additional PR once this one is merged.

@michalvavrik
Copy link
Member Author

Failures are expected, compilation is fixed, therefore this PR does what it says.

@jcarranzan jcarranzan merged commit 9c575bd into quarkus-qe:main Nov 15, 2023
6 of 8 checks passed
@michalvavrik michalvavrik deleted the feature/disable-sr-opentracing-ext branch November 15, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants