Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenTelemetry extension in Build-tiime Analytics module as OpenTracing is deprecated and not released yet #1520

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 15, 2023

Summary

Fixes CI. #1519 follow-up

https://docs.quarkiverse.io/quarkus-smallrye-opentracing/dev/index.html says we should use OpenTelemetry. There is no deeper logic why this module used OpenTracing extension (like product requirement or RH ticket etc.), so here we can safely replace it with preferred version.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan
Copy link
Contributor

It looks good to me, waiting for CI jobs

@jcarranzan
Copy link
Contributor

Native build failed, is it expected?

@michalvavrik
Copy link
Member Author

Native build failed, is it expected?

No, but it failed over Terminating due to java.lang.OutOfMemoryError: GC overhead limit exceeded and I don't believe OpenTelemtry made the difference. It's as simple as: the test is building native executable image with too many extensions and you can only hope GH CI runner will have enough of space. I'd suggest to watch daily builds and if it happens repeatedly, make lighter executable in GH.

@michalvavrik
Copy link
Member Author

btw. I totally experienced it in past...

@jcarranzan jcarranzan merged commit 60a3643 into quarkus-qe:main Nov 15, 2023
6 of 7 checks passed
@michalvavrik michalvavrik deleted the feature/fix-build-time-analytics-use-otel branch November 15, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants