-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Vert.x web validation module #1516
Conversation
...tx-web-validation/src/test/java/io/quarkus/ts/vertx/web/validation/VertxWebValidationIT.java
Outdated
Show resolved
Hide resolved
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Outdated
Show resolved
Hide resolved
64d6ad8
to
2861266
Compare
86d8e40
to
1b93ae8
Compare
...lidation/src/test/java/io/quarkus/ts/vertx/web/validation/OpenshiftVertxWebValidationIT.java
Outdated
Show resolved
Hide resolved
dfd64a8
to
a122069
Compare
It seems CI fails now because opentracing jar is missing: https://repo.maven.apache.org/maven2/io/quarkiverse/opentracing/quarkus-smallrye-opentracing/1.0.0/quarkus-smallrye-opentracing-1.0.0.pomOpentracing and also according to this: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.6 |
It's consequence of quarkusio/quarkus#36602 and it needs to be fixed. I'll do it in a moment. |
Ok, currently after our PR merged(#1519 and #1520) into main all the CI passed successfully. |
run tests |
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Outdated
Show resolved
Hide resolved
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Outdated
Show resolved
Hide resolved
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Outdated
Show resolved
Hide resolved
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Show resolved
Hide resolved
http/vertx-web-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ShopResource.java
Outdated
Show resolved
Hide resolved
eb0c75b
to
017a5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, one last thing - please squash your commits
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Outdated
Show resolved
Hide resolved
...b-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ValidationHandlerOnRoutes.java
Show resolved
Hide resolved
1edbd07
to
b404307
Compare
b404307
to
fbee453
Compare
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice job.
Summary
This module covers the functionality of Vert.x web validation (https://vertx.io/docs/vertx-web-validation/java/), basically provides an API to build a handler that performs parsing and validation of the requests.
Please select the relevant options.
run tests
phrase in comment)Checklist: