Fix docs workflow failure due to Fiona package #2008
Conversation
|
I added |
|
Can't get Fiona to install from the requirements. Instead I just install it with Pip explicitely. Not the nicest solution but it does work. |
| # For some reason Fiona doesn't get installed from requirements-dev... | ||
| - name: Install fiona dependency | ||
| shell: bash -l {0} | ||
| run: python -m pip install fiona |
There was a problem hiding this comment.
If you can wait I'll take a look at this next week. Something is not right here...
There was a problem hiding this comment.
something's weird right! I can definitely wait, very interesting to figure out what's going on.
Note that #2007 is waiting for the fix to get the docs going again. Waiting a week is not an issue, but if it's much longer then maybe a quick fix now and looking into it later is better. Definitely not meant to rush you! More of an expectation thing.
I did also manage to fix the Selenium heatmap test issue in this PR, but I'll spin that out in a separate one and merge that earlier.
There was a problem hiding this comment.
I split the underlying issues for the Selenium heatmap and this change. Once we have both fixed shall we make a new release?
There was a problem hiding this comment.
something's weird right! I can definitely wait, very interesting to figure out what's going on.
Found it. See #2012. Basically we are limiting to what is on main to build/test the docs.
Conengmo
changed the title
|
Close this one in favor of #2012 |
Closes #2002
Add
fionaas an explicit dev dependency.It is needed in this example in the docs https://python-visualization.github.io/folium/latest/user_guide/geojson/geopandas_and_geo_interface.html#Use-any-object-with-__geo_interface__
The other issue is with the heatmap verification. Seems like Chrome added some UI element to the headless browser that changed the window size. So I updated the verification image to correspond with the new size.
But now the size differ between my local computer and the remove env. I guess we should either rewrite this test to not be dependent on screen size or scrap it altogether.