Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs workflow failure due to Fiona package #2008

Closed
wants to merge 13 commits into from
5 changes: 5 additions & 0 deletions .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ jobs:
--file requirements.txt
--file requirements-dev.txt

# For some reason Fiona doesn't get installed from requirements-dev...
- name: Install fiona dependency
shell: bash -l {0}
run: python -m pip install fiona
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can wait I'll take a look at this next week. Something is not right here...

Copy link
Member Author

@Conengmo Conengmo Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something's weird right! I can definitely wait, very interesting to figure out what's going on.

Note that #2007 is waiting for the fix to get the docs going again. Waiting a week is not an issue, but if it's much longer then maybe a quick fix now and looking into it later is better. Definitely not meant to rush you! More of an expectation thing.

I did also manage to fix the Selenium heatmap test issue in this PR, but I'll spin that out in a separate one and merge that earlier.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split the underlying issues for the Selenium heatmap and this change. Once we have both fixed shall we make a new release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something's weird right! I can definitely wait, very interesting to figure out what's going on.

Found it. See #2012. Basically we are limiting to what is on main to build/test the docs.


- name: Install folium from source
shell: bash -l {0}
run: python -m pip install -e . --no-deps --force-reinstall
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ altair>=5.0.0
cartopy
check-manifest
descartes
fiona
flake8
flake8-builtins
flake8-comprehensions
Expand Down
3 changes: 2 additions & 1 deletion tests/selenium/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ def __init__(self):
options.add_argument("--no-sandbox")
options.add_argument("--disable-dev-shm-usage")
options.add_argument("--disable-gpu")
options.add_argument("--headless")
options.add_argument("--headless=new")
options.add_argument("--window-size=1024,768")
options.add_argument("--test-type")
super().__init__(options=options)

def get_file(self, filepath):
Expand Down
5 changes: 5 additions & 0 deletions tests/selenium/test_heat_map_selenium.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ def test_heat_map_with_weights(driver):
driver.verify_js_logs()
canvas = driver.wait_until("canvas.leaflet-heatmap-layer")
assert canvas
# Print the canvas size
canvas_size = driver.execute_script(
"return {width: arguments[0].width, height: arguments[0].height};", canvas
)
print(f"Canvas size: {canvas_size['width']}x{canvas_size['height']}")
# get the canvas as a PNG base64 string
canvas_base64 = driver.execute_script(
"return arguments[0].toDataURL('image/png').substring(21);", canvas
Expand Down
Binary file modified tests/selenium/test_heat_map_selenium_screenshot.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading