Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fiona and ensure latest geopandas #2012

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Oct 21, 2024

Testing if we can build the docs properly. Alternative for #2008.

Co-authored-by: Frank Anema <[email protected]>
@Conengmo
Copy link
Member

Conengmo commented Oct 21, 2024

Looks good, but now the code tests on Python 3.8 are failing. Looks like Geopandas 1.0 requires Python >= 3.9, so we should update thoses tests from 3.8 to 3.9.

Testing for 3.13 is not working yet it seems.

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything passes now!

Thanks for finding the issue @ocefpaf!

@ocefpaf
Copy link
Member Author

ocefpaf commented Oct 21, 2024

Testing for 3.13 is not working yet it seems.

I'm working on this upstream. It should be OK in 1-2 days.

@ocefpaf ocefpaf merged commit 9a69958 into python-visualization:main Oct 21, 2024
12 checks passed
@ocefpaf ocefpaf deleted the fiona branch October 21, 2024 14:30
@Conengmo
Copy link
Member

If it's that quick then let's include it in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants