Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Batch Scraping Configuration #173

Merged
merged 9 commits into from
Oct 25, 2024

Conversation

hkfgo
Copy link
Contributor

@hkfgo hkfgo commented Oct 2, 2024

Fixes #

@hkfgo
Copy link
Contributor Author

hkfgo commented Oct 24, 2024

Not sure why those deploy checks failed, since Helm lint appears to think this chart is perfectly fine :)

I'm gonna pull in this chart to run in our staging env. Will report back

@hkfgo
Copy link
Contributor Author

hkfgo commented Oct 24, 2024

Btw, it'd be great if you can cut a new Promitor release soon(no pressure)! We'd accumulated a good amount of feature changes as well as CVEs(tomkerkhove/promitor#2538 and tomkerkhove/promitor#2542). Users like me are eager to try out a new release in production.

@tomkerkhove
Copy link
Member

Sure but docs/helm needs to be ready as well.

Did you try this Helm chart locally? I see startup failures here, but can be outdated secret

@hkfgo
Copy link
Contributor Author

hkfgo commented Oct 25, 2024

Sure but docs/helm needs to be ready as well.

Did you try this Helm chart locally? I see startup failures here, but can be outdated secret

I suspect it's an outdated secret. I tried running with configmap and values files from master, and still couldn't pass the CI. Do you mind checking those?

The logs aren't too helpful here :/ It looks like the top of the table was cut off, so we can't see what step has failed. What's not shown here are 3 validations steps - configuration path, Azure auth credentials(our suspect), and metrics declaration

Current container logs
┃ Resource Discovery               │ Success │ Everything is well-configured.  ┃
┃ Atlassian Statuspage Metric Sink │ Success │ Everything is well-configured.  ┃
┃ OpenTelemetry Collector Metric   │ Success │ Everything is well-configured.  ┃
┃ Sink                             │         │                                 ┃
┃ Prometheus Scraping Endpoint     │ Success │ Everything is well-configured.  ┃
┃ Metric Sink                      │         │                                 ┃
┃ StatsD Metric Sink               │ Success │ Everything is well-configured.  ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┷━━━━━━━━━┷━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

@hkfgo
Copy link
Contributor Author

hkfgo commented Oct 25, 2024

And yeah, I've tested my chart changes in staging env, where I configured our Promitor deployments to do batch scraping by default. Everything looks to be working so far

@hkfgo hkfgo force-pushed the feat/add-batch-scraping-flag branch from 6595953 to a5ca6f0 Compare October 25, 2024 08:01
@tomkerkhove
Copy link
Member

I trust you

@tomkerkhove tomkerkhove merged commit cbe1b10 into promitor:main Oct 25, 2024
8 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants