-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable Batch Scraping Configuration #173
feat: Enable Batch Scraping Configuration #173
Conversation
Not sure why those deploy checks failed, since Helm lint appears to think this chart is perfectly fine :) I'm gonna pull in this chart to run in our staging env. Will report back |
Btw, it'd be great if you can cut a new Promitor release soon(no pressure)! We'd accumulated a good amount of feature changes as well as CVEs(tomkerkhove/promitor#2538 and tomkerkhove/promitor#2542). Users like me are eager to try out a new release in production. |
Sure but docs/helm needs to be ready as well. Did you try this Helm chart locally? I see startup failures here, but can be outdated secret |
I suspect it's an outdated secret. I tried running with The logs aren't too helpful here :/ It looks like the top of the table was cut off, so we can't see what step has failed. What's not shown here are 3 validations steps - configuration path, Azure auth credentials(our suspect), and metrics declaration
|
And yeah, I've tested my chart changes in staging env, where I configured our Promitor deployments to do batch scraping by default. Everything looks to be working so far |
6595953
to
a5ca6f0
Compare
I trust you |
Fixes #