Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Batch Scraping Configuration #173

Merged
merged 9 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions promitor-agent-scraper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ their default values.
| `azureMonitor.logging.enabled` | Indication whether or not to provide logs on the integration with Azure Monitor and its APIs | `false` |
| `azureMonitor.logging.logLevel` | Minimum level of logging for Azure Monitor interactions | N/A |
| `azureMonitor.integration.useAzureMonitorSdk` | Whether to use the Azure Monitor SDK for scraping; alternative is the legacy Azure Management Library | `true`
| `azureMonitor.integration.metricsBatching.enabled` | Whether to scrape metrics in batch mode | `false`
| `azureMonitor.integration.metricsBatching.maxBatchSize` | Max number of resources within a batch | `50`
| `azureMonitor.integration.metricsBatching.azureRegion` | Azure region of resource targets for batching |
| `azureMonitor.integration.history.startingFromInHours` | Defines the amount of hours Promitor will use to define the starting point of the time window used for metric queries. | N/A |
| `rbac.create` | If true, create & use RBAC resources | `true` |
| `rbac.podSecurityPolicyEnabled` | Create pod security policy resources | `false` |
Expand Down
10 changes: 8 additions & 2 deletions promitor-agent-scraper/templates/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ data:
verbosity: {{ .Values.telemetry.containerLogs.logLevel | quote }}
{{- end }}
defaultVerbosity: {{ .Values.telemetry.defaultLogLevel | quote }}
{{- if or .Values.azureMonitor.logging.enabled .Values.azureMonitor.integration.history.startingFromInHours .Values.azureMonitor.integration.useAzureMonitorSdk }}
{{- if hasKey .Values "azureMonitor" }}
azureMonitor:
{{- if .Values.azureMonitor.logging.enabled }}
logging:
Expand All @@ -78,8 +78,14 @@ data:
{{- end }}
isEnabled: {{ .Values.azureMonitor.logging.enabled | quote }}
{{- end }}
{{- if .Values.azureMonitor.integration.history.startingFromInHours }}
{{- if hasKey .Values.azureMonitor "integration" }}
integration:
{{- if hasKey .Values.azureMonitor.integration "metricsBatching" }}
metricsBatching:
enabled: true
maxBatchSize: {{ .Values.azureMonitor.integration.metricsBatching.maxBatchSize }}
azureRegion: {{ .Values.azureMonitor.integration.metricsBatching.azureRegion }}
{{- end }}
useAzureMonitorSdk: {{ .Values.azureMonitor.integration.useAzureMonitorSdk | quote}}
history:
startingFromInHours: {{ .Values.azureMonitor.integration.history.startingFromInHours }}
Expand Down
Loading