Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable Batch Scraping Configuration #173

Merged
merged 9 commits into from
Oct 25, 2024
Merged

feat: Enable Batch Scraping Configuration #173

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3f81cd
Make batch scraping configurable
hkfgo Oct 2, 2024
722c845
simplify if statements
hkfgo Oct 24, 2024
83d2f6f
simplify if statements
hkfgo Oct 24, 2024
adbd40e
Add if checks
hkfgo Oct 25, 2024
bb7a432
starting from master version
hkfgo Oct 25, 2024
e5c9ebd
Add proper if logic
hkfgo Oct 25, 2024
5586aba
Add batching value
hkfgo Oct 25, 2024
6b69b08
Add batching value
hkfgo Oct 25, 2024
a5ca6f0
Add batching value
hkfgo Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions promitor-agent-scraper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ their default values.
| `azureMonitor.logging.enabled` | Indication whether or not to provide logs on the integration with Azure Monitor and its APIs | `false` |
| `azureMonitor.logging.logLevel` | Minimum level of logging for Azure Monitor interactions | N/A |
| `azureMonitor.integration.useAzureMonitorSdk` | Whether to use the Azure Monitor SDK for scraping; alternative is the legacy Azure Management Library | `true`
| `azureMonitor.integration.metricsBatching.enabled` | Whether to scrape metrics in batch mode | `false`
| `azureMonitor.integration.metricsBatching.maxBatchSize` | Max number of resources within a batch | `50`
| `azureMonitor.integration.metricsBatching.azureRegion` | Azure region of resource targets for batching |
| `azureMonitor.integration.history.startingFromInHours` | Defines the amount of hours Promitor will use to define the starting point of the time window used for metric queries. | N/A |
| `rbac.create` | If true, create & use RBAC resources | `true` |
| `rbac.podSecurityPolicyEnabled` | Create pod security policy resources | `false` |
Expand Down
8 changes: 7 additions & 1 deletion promitor-agent-scraper/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,14 @@ data:
{{- end }}
isEnabled: {{ .Values.azureMonitor.logging.enabled | quote }}
{{- end }}
{{- if .Values.azureMonitor.integration.history.startingFromInHours }}
{{- if or .Values.azureMonitor.logging.enabled .Values.azureMonitor.integration.history.startingFromInHours .Values.azureMonitor.integration.useAzureMonitorSdk}}
integration:
{{- if .Values.azureMonitor.integration.metricsBatching.enabled }}
metricsBatching:
enabled: true
maxBatchSize: {{ .Values.azureMonitor.integration.metricsBatching.maxBatchSize }}
azureRegion: {{ .Values.azureMonitor.integration.metricsBatching.azureRegion }}
{{- end }}
useAzureMonitorSdk: {{ .Values.azureMonitor.integration.useAzureMonitorSdk | quote}}
history:
startingFromInHours: {{ .Values.azureMonitor.integration.history.startingFromInHours }}
Expand Down
Loading