-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spell.yml #32132
Update spell.yml #32132
Conversation
Update the spell checker used
PR #32132: Size comparison from 14aac83 to 31984b6 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Remove defaultValue, an example of the camelcase we are working around, to trigger test on PR
PR #32132: Size comparison from 274719d to f725c62 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32132: Size comparison from 8d30071 to 6b002dc Full report (7 builds for cc32xx, mbed, nrfconnect, stm32)
|
PR #32132: Size comparison from 8d30071 to 1335993 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
@kliao-csa - this should have been going through a regular review process as it is not a separate example/tool. |
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
# Seems redundant; removed as pyspelling is customized while this is not | ||
# check-reviewdog: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment staying in the source code will lose context. Pyspelling is not there anymore, only spellcheck-github-actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll remove this comment and clarify in some documentation.
* Update spell.yml Update the spell checker used * Update .wordlist.txt Remove defaultValue, an example of the camelcase we are working around, to trigger test on PR * Update .spellcheck.yml camelcase true * Update spell.yml * Wordlist camelcase removal * Update .wordlist.txt
Update the spell checker used in pyspelling checker to rojopolis/[email protected] that is used in chip-test-plans