Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spell.yml #32132

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Update spell.yml #32132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
580fdb2
Update spell.yml
kliao-csa Feb 9, 2024
31984b6
Merge branch 'master' into issue-31602
kliao-csa Feb 14, 2024
84773d4
Update .wordlist.txt
kliao-csa Feb 14, 2024
f725c62
Merge branch 'master' into issue-31602
kliao-csa Feb 14, 2024
45baf23
Merge branch 'master' into issue-31602
kliao-csa Feb 15, 2024
cda7345
Update .spellcheck.yml camelcase true
kliao-csa Feb 15, 2024
6b002dc
Update spell.yml
kliao-csa Feb 15, 2024
bd14094
Wordlist camelcase removal
kliao-csa Feb 15, 2024
1335993
Update .wordlist.txt
kliao-csa Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 2 additions & 32 deletions .github/.wordlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,29 +14,19 @@ abfb
ABI
ABIs
ables
AccessControl
AccessControlEntry
accesscontrol
accessor
Accessors
AccountLogin
acdbc
ack
ACKed
ACL
ACLs
actdiag
AdapterAddress
AdapterName
adb
AddNOC
AddOrUpdateThreadNetwork
AddOrUpdateWiFiNetwork
addr
AddResponse
AddThreadNetwork
AddStatus
adk
AdministratorCommissioning
adoc
adr
AdvAutonomous
Expand All @@ -48,7 +38,6 @@ AE
aef
AES
AIDL
AlarmCode
algs
alloc
Ameba
Expand All @@ -61,15 +50,12 @@ AnnounceOTAProvider
AnnounceOTAProviderRequest
APIs
apk
AppConfig
AppImpl
AppleTV
appliable
ApplianceControl
applianceeventsandalert
ApplianceIdentification
appliancestatistics
ApplicationBasic
ApplicationId
ApplicationIdentifier
ApplicationLauncher
Expand Down Expand Up @@ -171,7 +157,6 @@ BRD
breakpoint
bredr
BridgedDeviceBasicInformation
bridgedLightEndpoint
bringup
BroadcastReceiver
BromateConcentrationMeasurement
Expand Down Expand Up @@ -259,9 +244,6 @@ CLIs
cloudbuild
CLRF
clusterAttrs
clusterId
clusterList
clusterListName
ClusterName
ClusterObjectTests
ClusterRevision
Expand Down Expand Up @@ -315,7 +297,6 @@ ContentApp's
ContentAppPlatform
ContentLaunch
ContentLauncher
continuousHinting
contrib
controllee
conv
Expand Down Expand Up @@ -382,7 +363,6 @@ DefaultOTARequestor
DefaultOTARequestorDriver
DefaultOTARequestorStorage
DefaultSuccess
defaultValue
definedValue
DehumidificationControl
DelayedActionTime
Expand Down Expand Up @@ -415,9 +395,7 @@ DeviceLayer
DeviceNetworkProvisioningDelegate
DeviceNetworkProvisioningDelegateImpl
DevicePairingDelegate
deviceSoftwareVersionModel
DeviceTemperatureConfiguration
deviceType
DevKitC
DevKitM
devtype
Expand Down Expand Up @@ -511,8 +489,6 @@ EnableNetwork
EnableWiFiNetwork
endian
EndpointId
endpointName
endsWith
eno
entrypoint
enum
Expand Down Expand Up @@ -579,7 +555,6 @@ FlowMeasurement
FluorideConcentrationMeasurement
focusable
forkpty
formatOnSave
FOTA
FreeRTOS
FreeRTOSConfig
Expand Down Expand Up @@ -613,7 +588,6 @@ GetIP
getManualTests
GetSafeAttributePersistenceProvider
getstarted
getTests
GH
ghcr
ghp
Expand All @@ -638,8 +612,6 @@ graphviz
Groupcast
GroupId
GroupKeyManagement
groupKeySecurityPolicy
groupKeySetID
groupsettings
gsdk
gtk
Expand Down Expand Up @@ -693,8 +665,6 @@ ifconfig
ifdef
ifdefs
IGMP
ignoreApplyUpdate
ignoreQueryImage
ihex
IlluminanceMeasurement
IM
Expand Down Expand Up @@ -1621,4 +1591,4 @@ zephyrproject
zhengyaohan
Zigbee
zigbeealliance
zigbeethread
zigbeethread
21 changes: 11 additions & 10 deletions .github/workflows/spell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,20 @@ on:
- ".github/.wordlist.txt"

jobs:
check-reviewdog:
name: Check Spelling - reviewdog
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: reviewdog/action-misspell@v1
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Seems redundant; removed as pyspelling is customized while this is not
# check-reviewdog:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment staying in the source code will lose context. Pyspelling is not there anymore, only spellcheck-github-actions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove this comment and clarify in some documentation.

# name: Check Spelling - reviewdog
# runs-on: ubuntu-latest
# steps:
# - name: Checkout
# uses: actions/checkout@v4
# - uses: reviewdog/action-misspell@v1
# with:
# github_token: ${{ secrets.GITHUB_TOKEN }}
check-spellcheck:
name: Check Spelling - pyspelling
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: igsekor/[email protected]
- uses: rojopolis/[email protected]
kliao-csa marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions .spellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,4 @@ matrix:
- '**/*.md|!third_party/**|!examples/common/**/repo/**|!docs/ERROR_CODES.md|!docs/clusters.md|!docs/testing/yaml_schema.md|!docs/testing/yaml_pseudocluster.md'
aspell:
ignore-case: true
camel-case: true
Loading