Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] update pyspelling in SDK to support camel-case #31602

Closed
cecille opened this issue Jan 22, 2024 · 3 comments · Fixed by #32132
Closed

[Tooling] update pyspelling in SDK to support camel-case #31602

cecille opened this issue Jan 22, 2024 · 3 comments · Fixed by #32132
Assignees
Labels
CI/CD improvements Improvements to our CI/CD pipelines needs triage tools

Comments

@cecille
Copy link
Contributor

cecille commented Jan 22, 2024

Reproduction steps / Feature

newer versions fixed the camel-case option to aspell. The spec repo uses this version. We should update the SDK to do the same. Then we can remove some of the excluded files from the spell checker.

Platform

python

Platform Version(s)

No response

Type

CI tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

@cecille cecille added tools needs triage CI/CD improvements Improvements to our CI/CD pipelines labels Jan 22, 2024
@cecille
Copy link
Contributor Author

cecille commented Jan 22, 2024

It's also unclear why we have two spell checkers running - it's probably worthwhile to consolidate these.

@cecille
Copy link
Contributor Author

cecille commented Jan 22, 2024

After updating, we should also prune the wordlist to exclude the things that were added to work around not having camel case. When we did this in the spec, we found lots of spelling errors.

@kliao-csa kliao-csa self-assigned this Feb 5, 2024
@kliao-csa kliao-csa linked a pull request Feb 15, 2024 that will close this issue
@kliao-csa
Copy link
Contributor

Pyspelling updated, Reviewdog commented out
Slowly removing camelcase entries from the wordlist - regex indicates there are a few hundred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD improvements Improvements to our CI/CD pipelines needs triage tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants