Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not error while parsing SDK python tests #141

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Do not error while parsing SDK python tests #141

merged 4 commits into from
Oct 23, 2024

Conversation

hiltonlima
Copy link
Contributor

  • Replace error with warning

@hiltonlima hiltonlima self-assigned this Sep 9, 2024
ccruzagralopes
ccruzagralopes approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ccruzagralopes ccruzagralopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion + typo

test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py Outdated Show resolved Hide resolved
@hiltonlima hiltonlima changed the base branch from main to spring2025 September 26, 2024 15:36
@hiltonlima hiltonlima merged commit ae490d4 into spring2025 Oct 23, 2024
8 checks passed
hiltonlima added a commit that referenced this pull request Oct 24, 2024
@hiltonlima @ccruzagralopes
Do not error while parsing SDK python tests (#141)
0585d43 
* replace erro with warning

* Update test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py

Co-authored-by: Carolina Lopes <[email protected]>

* black error fix

* pr review

---------

Co-authored-by: Carolina Lopes <[email protected]>
hiltonlima added a commit that referenced this pull request Dec 17, 2024
@hiltonlima @ccruzagralopes
Do not error while parsing SDK python tests (#141)
fddd789 
* replace erro with warning

* Update test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py

Co-authored-by: Carolina Lopes <[email protected]>

* black error fix

* pr review

---------

Co-authored-by: Carolina Lopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio-amjr antonio-amjr antonio-amjr approved these changes

@ccruzagralopes ccruzagralopes ccruzagralopes approved these changes

@rquidute rquidute rquidute approved these changes

@gladystonfranca gladystonfranca Awaiting requested review from gladystonfranca

Assignees

@hiltonlima hiltonlima

Labels
v1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiltonlima @rquidute @ccruzagralopes @antonio-amjr