Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not error while parsing SDK python tests #141

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Do not error while parsing SDK python tests #141

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3a7987
replace erro with warning
hiltonlima Sep 9, 2024
0f42545
Update test_collections/matter/sdk_tests/support/python_testing/model…
hiltonlima Sep 9, 2024
e44f9bc
black error fix
hiltonlima Sep 9, 2024
bd15f75
pr review
hiltonlima Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ def __parse_test_case(
try:
tc_desc = __retrieve_description(desc_method)
except Exception as e:
logger.error(
f"Error while parsing description for {tc_name}, Error:{str(e)}"
logger.warning(
f"Fail parsing description methood for {tc_name}, Error:{str(e)}"
hiltonlima marked this conversation as resolved.
Show resolved Hide resolved
)

# If the python test does not implement the steps template method,
Expand All @@ -170,14 +170,14 @@ def __parse_test_case(
try:
tc_steps = __retrieve_steps(steps_method)
except Exception as e:
logger.error(f"Error while parsing steps for {tc_name}, Error:{str(e)}")
logger.warning(f"Fail parsing steps method for {tc_name}, Error:{str(e)}")

pics_method = __get_method_by_name(pics_method_name, methods)
if pics_method:
try:
tc_pics = __retrieve_pics(pics_method)
except Exception as e:
logger.error(f"Error while parsing PICS for {tc_name}, Error:{str(e)}")
logger.warning(f"Fail parsing PICS method for {tc_name}, Error:{str(e)}")

# - PythonTestType.COMMISSIONING: test cases that have a commissioning first step
# - PythonTestType.NO_COMMISSIONING: test cases that follow the expected template
Expand Down Expand Up @@ -237,7 +237,9 @@ def __retrieve_steps(method: FunctionDefType) -> List[MatterTestStep]:
step_name = step.args[ARG_STEP_DESCRIPTION_INDEX].value
parsed_step_name = step_name
except Exception as e:
logger.error(f"Error while parsing step from {method.name}, Error:{str(e)}")
logger.warning(
f"Fail parsing step name from {method.name}, Error:{str(e)}"
)
parsed_step_name = "UNABLE TO PARSE TEST STEP NAME"

python_steps.append(
Expand Down
Loading