Skip to content

Commit

Permalink
Do not error while parsing SDK python tests (#141)
Browse files Browse the repository at this point in the history
* replace erro with warning

* Update test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py

Co-authored-by: Carolina Lopes <[email protected]>

* black error fix

* pr review

---------

Co-authored-by: Carolina Lopes <[email protected]>
  • Loading branch information
hiltonlima and ccruzagralopes committed Dec 17, 2024
1 parent 55afab5 commit fddd789
Showing 1 changed file with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ def __parse_test_case(
try:
tc_desc = __retrieve_description(desc_method)
except Exception as e:
logger.error(
f"Error while parsing description for {tc_name}, Error:{str(e)}"
logger.warning(
f"Failed parsing description method for {tc_name}, Error:{str(e)}"
)

# If the python test does not implement the steps template method,
Expand All @@ -173,14 +173,14 @@ def __parse_test_case(
try:
tc_steps = __retrieve_steps(steps_method)
except Exception as e:
logger.error(f"Error while parsing steps for {tc_name}, Error:{str(e)}")
logger.warning(f"Failed parsing steps method for {tc_name}, Error:{str(e)}")

pics_method = __get_method_by_name(pics_method_name, methods)
if pics_method:
try:
tc_pics = __retrieve_pics(pics_method)
except Exception as e:
logger.error(f"Error while parsing PICS for {tc_name}, Error:{str(e)}")
logger.warning(f"Failed parsing PICS method for {tc_name}, Error:{str(e)}")

# - PythonTestType.COMMISSIONING: test cases that have a commissioning first step
# - PythonTestType.NO_COMMISSIONING: test cases that follow the expected template
Expand Down Expand Up @@ -240,7 +240,9 @@ def __retrieve_steps(method: FunctionDefType) -> List[MatterTestStep]:
step_name = step.args[ARG_STEP_DESCRIPTION_INDEX].value
parsed_step_name = step_name
except Exception as e:
logger.error(f"Error while parsing step from {method.name}, Error:{str(e)}")
logger.warning(
f"Failed parsing step name from {method.name}, Error:{str(e)}"
)
parsed_step_name = "UNABLE TO PARSE TEST STEP NAME"

python_steps.append(
Expand Down

0 comments on commit fddd789

Please sign in to comment.