fixed #14716 and fixed #14757 - updated computed label logic to also handle disabled selected option #14768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) when computing the label, use all options verses just visible options this new logic will find the selected option whether or not the user is currently filtering because the filtered (i.e. visible) options, are a subset of all the options 2) When finding selected option, consider all options even those that have been disabled
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rosenthalj
changed the title
cetincakiroglu
approved these changes
Feb 14, 2024
|
Hi @rosenthalj Thanks a lot for the effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #14716
Fixed #14757
re-fixed #14596 - v17.6.0 broke changes that were made in v17.5.0 that were used to fix issue #14596
The changes:
Note: These changes supersedes PR #14759. This PR contains all the changes of #14759 (change (1)) plus change (2)
Please see the annotated screenshot and the video listed below which shows the fixed issue #14716
dropdownDisabledOptionFix.mov