Fixed #14815 - improved logic when modelValue is null and selected option value is null #14821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion value is null Added new method isModelValueNotSet to test for special case where modelValue is set because (modelValue is null and the selected option has a value of null ) I also renamed method isOptionEqualsModelValue to isOptionEqualsModelValue which is a more descriptive name. Note: in a previous PR that was accepted I refactored the code that resulted in the original isOptionEqualsModelValue method
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks a lot for the effort and support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #14815
The video listed below shows the issue #14815 reducer working after the fix (Note "All" option corresponds to
{name: 'All',code: null})drodownFix.mov
Note: I verified the fix did not break any of the PrimeNG demo dropdown examples
The issue was caused by a special case where the modelValue is null but the selected option's value is also null.
As part of the PR, I also renamed the method isOptionEqualsModelValue to isOptionEqualsModelValue which is a more descriptive name. Note: in a previous PR #14768 that was accepted I refactored the code that resulted in the original isOptionEqualsModelValue method