Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #14757 - "improved" computed label #14759

Closed

Conversation

rosenthalj
Copy link
Contributor

@rosenthalj rosenthalj commented Feb 7, 2024

fixed #14757

I implemented "improved" label logic.
re-fixed #14596 - v17.6.0 broke changes that were made in v17.5.0 that were used to fix issue #14596

Note: This PR is superseded by PR #14768 which fixes both this issue (#14757) and issue #14716

when computing the label,  use  all options verses just visible options
this new logic will find the selected option whether or not the user is currently filtering  because the filtered (i.e. visible) options, are a subset of all the options
Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 10:03pm

@cetincakiroglu
Copy link
Contributor

Hi,

Mentioned issue has been fixed already. I'm closing this one. Thanks a lot for the effort and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants